Close AudioContext when recording visualization stops#49
Open
afq984 wants to merge 1 commit into
Open
Conversation
Each recording created a new AudioContext for the waveform AnalyserNode but never closed it. Browsers limit the number of concurrent AudioContexts, so after ~40 record/stop cycles new contexts fail to start: getByteFrequencyData() returns silence (the waveform stops appearing) and audio decode/playback breaks until the page is refreshed. Close the AudioContext in the draw loop once the stream is no longer active, mirroring the cleanup already done in the download handler. Bug: b/538354264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each recording created a new AudioContext for the waveform AnalyserNode but never closed it. Browsers limit the number of concurrent AudioContexts, so after ~40 record/stop cycles new contexts fail to start: getByteFrequencyData() returns silence (the waveform stops appearing) and audio decode/playback breaks until the page is refreshed.
Close the AudioContext in the draw loop once the stream is no longer active, mirroring the cleanup already done in the download handler.
Bug: b/538354264